Issue 2494043: Remove bus_input_context_register_properties(props_empty) call from the focus out handler.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2494043: Remove bus_input_context_register_properties(props_empty) call from the focus out handler. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Yusuke Sato

Modified:
15 years, 4 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git

Visibility:
Public.

Description

Remove bus_input_context_register_properties(props_empty) call from the focus out handler. - On Chrome OS, the call is unnecessary since an ibus engine is always active on the OS. i.e. We use the xkb:us::eng engine even for ASCII input. - Unlike the standard Gtk+ language bar, the UI for Chrome OS _does_ grab keyboard focus. This means when the UI is used, focus-out signal is sent to ibus-daemon. Clearing a properties inside focus out handler sometimes confuses the UI (see http://crosbug.com/7702). BUG=chromium-os:7702 TEST=see the bug.

Patch Set 1 #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	bus/inputcontext.c	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

forgot to mention: this change is for the chromeos branch of ibus.

15 years, 4 months ago (2010-10-18 06:33:51 UTC) #2

Peng

15 years, 4 months ago (2010-10-19 07:42:47 UTC) #3

On 2010/10/18 06:33:51, Yusuke Sato wrote:
> forgot to mention: this change is for the chromeos branch of ibus.

LGTM

Expand All Messages | Collapse All Messages