Issue 2493043: code review 2493043: release.2010-10-13.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2493043: code review 2493043: release.2010-10-13.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by adg

Modified:
13 years, 6 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

release.2010-10-13.1

Patch Set 1 #

Patch Set 2 : code review 2493043: release.2010-10-13.1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	doc/devel/release.html	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 6 months ago (2010-10-15 01:03:14 UTC) #1

LGTM On Oct 14, 2010, at 6:03 PM, adg@golang.org wrote: > Reviewers: r, > > ...

13 years, 6 months ago (2010-10-15 01:04:19 UTC) #2

LGTM

On Oct 14, 2010, at 6:03 PM, adg@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> release.2010-10-13.1
> 
> Please review this at http://codereview.appspot.com/2493043/
> 
> Affected files:
>  M .hgtags
>  M doc/devel/release.html
> 
> 
> Index: .hgtags
> ===================================================================
> --- a/.hgtags
> +++ b/.hgtags
> @@ -32,5 +32,3 @@
> 9329773e204fed50ec686ee78cc715b624bf1b1d release.2010-09-15
> 1eec33c03bceef5d7607ea4636185f7bf773e0e4 release.2010-09-22
> c2b8c9f13fb8ad2b56920d9da2928c5314ebf725 release.2010-09-29
> -7c2e97710bf49cdbe388260958a6674afefb6c0f release.2010-10-13
> -7c2e97710bf49cdbe388260958a6674afefb6c0f release
> Index: doc/devel/release.html
> ===================================================================
> --- a/doc/devel/release.html
> +++ b/doc/devel/release.html
> @@ -43,14 +43,17 @@
> Other changes:
> * 6l: Mach-O fixes, and fix to work with OS X nm/otool (thanks Jim McGrath).
> * [568]a: correct line numbers for statements.
> -* arm: code generation and runtime fixes
> +* arm: code generation and runtime fixes,
> +	adjust recover for new reflect.call,
> +	enable 6 more tests after net fix.
> * big: fix panic and round correctly in Rat.FloatString (thanks Anthony
Martin).
> * build: Make.cmd: remove $(OFILES) (thanks Eric Clark),
>         Make.pkg: remove .so before installing new one,
>         add GOHOSTOS and GOHOSTARCH environment variables.
> * crypto/tls: better error messages for certificate issues,
>         make SetReadTimeout work.
> -* doc: add Sydney University video to docs page.
> +* doc: add Sydney University video,
> +	add The Expressiveness of Go talk.
> * exp/draw/x11: support X11 vendors other than "The X.Org Foundation".
> * expvar: add (*Int).Set (thanks Sam Thorogood).
> * fmt: add Errorf helper function,
> 
>

adg

13 years, 6 months ago (2010-10-15 01:05:16 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ca4f9687cec0 ***

release.2010-10-13.1

R=r, r2
CC=golang-dev
http://codereview.appspot.com/2493043

Expand All Messages | Collapse All Messages