Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1722)

Issue 248950043: Enable to show a property on ibus panel icon (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by fujiwara
Modified:
8 years, 10 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Enable to show a property on ibus panel icon If an engine sets the value of icon-prop-key of IBusEngineDesc to a property name of IBusProperty.key, the panel will show the engine property in the icon with a delayed time. This way can show both the engine icon and the engine mode in one icon. Committed: 23c45b970b195008a54884a1a9d810e7f8b22c5c

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -5 lines) Patch
M data/ibus.schemas.in View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/ibusenginedesc.h View 3 chunks +14 lines, -2 lines 0 comments Download
M src/ibusenginedesc.c View 15 chunks +36 lines, -2 lines 0 comments Download
M ui/gtk3/panel.vala View 1 8 chunks +74 lines, -1 line 0 comments Download

Messages

Total messages: 6
fujiwara
8 years, 10 months ago (2015-06-17 08:55:44 UTC) #1
Peng
https://codereview.appspot.com/248950043/diff/1/data/ibus.schemas.in File data/ibus.schemas.in (right): https://codereview.appspot.com/248950043/diff/1/data/ibus.schemas.in#newcode310 data/ibus.schemas.in:310: <owner>ibus</owner> Seems the timeout is just for switching engine ...
8 years, 10 months ago (2015-06-17 14:07:24 UTC) #2
fujiwara
https://codereview.appspot.com/248950043/diff/1/data/ibus.schemas.in File data/ibus.schemas.in (right): https://codereview.appspot.com/248950043/diff/1/data/ibus.schemas.in#newcode310 data/ibus.schemas.in:310: <owner>ibus</owner> On 2015/06/17 14:07:24, Peng wrote: > Seems the ...
8 years, 10 months ago (2015-06-18 02:46:38 UTC) #3
fujiwara
https://codereview.appspot.com/248950043/diff/1/data/ibus.schemas.in File data/ibus.schemas.in (right): https://codereview.appspot.com/248950043/diff/1/data/ibus.schemas.in#newcode310 data/ibus.schemas.in:310: <owner>ibus</owner> On 2015/06/17 14:07:24, Peng wrote: > Seems the ...
8 years, 10 months ago (2015-06-18 04:45:39 UTC) #4
Peng
lgtm
8 years, 10 months ago (2015-06-18 15:56:47 UTC) #5
fujiwara
8 years, 10 months ago (2015-06-19 04:57:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
23c45b970b195008a54884a1a9d810e7f8b22c5c (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b