Issue 248042: Move all HTMLContentRewriter and *LinkRewriter to a separate package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 248042: Move all HTMLContentRewriter and *LinkRewriter to a separate package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by johnfargo

Modified:
15 years, 10 months ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

New package is simply labeled "old" signifying its deprecation from ongoing code maintenance. This allows several other CLs being handled right now (implementing a refactored HTMLContentRewriter, among other changes) to be done in parallel with this without risk of breaking existing users. The only necessary change for those overriding or manually injecting HTMLContentRewriter (or CssRequestRewriter) is to add ".old" to its package name. These classes will be removed once the "new" implementations are proven out.

Patch Set 1 #

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+1340 lines, -1691 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultSanitizingProxyingLinkRewriterFactory.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriter.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingProxyingLinkRewriter.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatLinkRewriter.java	View	1 chunk	+0 lines, -117 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatLinkRewriterFactory.java	View	1 chunk	+0 lines, -31 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ContentRewriterUris.java	View	1 chunk	+0 lines, -63 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java	View	1 chunk	+0 lines, -181 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/DefaultConcatLinkRewriterFactory.java	View	1 chunk	+0 lines, -46 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/DefaultProxyingLinkRewriterFactory.java	View	1 chunk	+0 lines, -43 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HTMLContentRewriter.java	View	1 chunk	+0 lines, -313 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/LinkRewriter.java	View	1 chunk	+0 lines, -30 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingLinkRewriter.java	View	1 chunk	+0 lines, -96 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingLinkRewriterFactory.java	View	1 chunk	+0 lines, -31 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/ConcatLinkRewriter.java	View	1 chunk	+118 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/ConcatLinkRewriterFactory.java	View	1 chunk	+32 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/ContentRewriterUris.java	View	1 chunk	+63 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/CssRequestRewriter.java	View	2 chunks	+7 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/DefaultConcatLinkRewriterFactory.java	View	1 chunk	+47 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/DefaultProxyingLinkRewriterFactory.java	View	1 chunk	+44 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/HTMLContentRewriter.java	View	1 chunk	+319 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/LinkRewriter.java	View	1 chunk	+30 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/ProxyingLinkRewriter.java	View	1 chunk	+97 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/ProxyingLinkRewriterFactory.java	View	1 chunk	+32 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizerTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/BaseRewriterTestCase.java	View	3 chunks	+6 lines, -3 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriterTest.java	View	1 chunk	+0 lines, -210 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/DefaultContentRewriterRegistryTest.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/HTMLContentRewriterTest.java	View	1 chunk	+0 lines, -407 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ProxyingLinkRewriterTest.java	View	1 chunk	+0 lines, -111 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/old/CssRequestRewriterTest.java	View	2 chunks	+7 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/old/HTMLContentRewriterTest.java	View	1 chunk	+412 lines, -0 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/old/ProxyingLinkRewriterTest.java	View	1 chunk	+115 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

zhoresh

15 years, 10 months ago (2010-03-05 21:52:05 UTC) #2

LGTM

I am not sure how by part of the attached patch is no complete. For example for:

java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/CssRequestRewriter.java

Expand All Messages | Collapse All Messages