Issue 247990043: Fixed the mechanism to detect XEN Paravirtualization being enabled. The previous check would activa…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 247990043: Fixed the mechanism to detect XEN Paravirtualization being enabled. The previous check would activa… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by Jordi

Modified:
8 years, 10 months ago

Reviewers:
scudette

CC:
rekall-dev_googlegroups.com

Base URL:
https://github.com/google/rekall.git@master

Visibility:
Public.

More Reviews

Description

Fixed the mechanism to detect XEN Paravirtualization being enabled. The previous check would activate XEN when running a paravirtualized kernel on bare hardware, where it's actually not enabled. Now we check the effects xen_setup_pv_ops() has on pv_info. BUG= R=scudette@gmail.com Committed: 2bf91176abd767d160810e14ea9d555e4c8935b9

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -12 lines)			Patch
	M	rekall/plugins/linux/common.py	View	1 2 3	1 chunk	+17 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jordi

Before, we'd detect Xen PV even when it's not actually active but the kernel has ...

8 years, 10 months ago (2015-06-13 01:14:11 UTC) #1

scudette

Lgtm Am 13.06.2015 3:14 vorm. schrieb <parki.san@gmail.com>: > https://codereview.appspot.com/247990043/ >

8 years, 10 months ago (2015-06-13 05:05:59 UTC) #3

Jordi

8 years, 10 months ago (2015-06-15 23:55:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
2bf91176abd767d160810e14ea9d555e4c8935b9 (presubmit successful).

Expand All Messages | Collapse All Messages