Fix enum support in GadgetHandlerService and add default locale

Two fixes:
- Use name instead of toString for automatic enum conversion (toString can be different).
- Add default locale for the service since the spec factory require locale internally.

[zhoresh, 2010-10-14 21:59:37]

Add handling for wrong case in names

[mhermanto, 2010-10-14 22:23:49]

Mostly nits.

http://codereview.appspot.com/2479042/diff/2001/java/common/src/main/java/org...
File
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java
(right):

http://codereview.appspot.com/2479042/diff/2001/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java:64:
public static String normalizeName(String name) {
Can be private, since others outside of this class/package don't seem to care
about it. Can be made public as needed easily.

http://codereview.appspot.com/2479042/diff/2001/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java:71:
public static Map<String, Object> normalizeFields(Map<String, Object> original)
{
Ditto.

http://codereview.appspot.com/2479042/diff/2001/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java:75:
builder.put(normalizeName(entry.getKey()), nullable(entry.getValue()));
Possible to have two conflicting names after they're normalized?

http://codereview.appspot.com/2479042/diff/2001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):

http://codereview.appspot.com/2479042/diff/2001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:61:
public static final Locale DEFAULT_LOCALE = new Locale("all", "all");
Ditto.

[mhermanto, 2010-10-14 22:58:35]

LGTM++

Talked offline. Public methods will be used externally. Name collissions are
possible but ImmutableMap will prevent it.

[zhoresh, 2010-10-14 22:59:23]

http://codereview.appspot.com/2479042/diff/2001/java/common/src/main/java/org...
File
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java
(right):

http://codereview.appspot.com/2479042/diff/2001/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java:64:
public static String normalizeName(String name) {
On 2010/10/14 22:23:49, mhermanto wrote:
> Can be private, since others outside of this class/package don't seem to care
> about it. Can be made public as needed easily.

I am using this utility in our proto delegator :)

http://codereview.appspot.com/2479042/diff/2001/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java:75:
builder.put(normalizeName(entry.getKey()), nullable(entry.getValue()));
On 2010/10/14 22:23:49, mhermanto wrote:
> Possible to have two conflicting names after they're normalized?

Yes, and ImmutableMap will throw an exception, which is what we want here

http://codereview.appspot.com/2479042/diff/2001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):

http://codereview.appspot.com/2479042/diff/2001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:61:
public static final Locale DEFAULT_LOCALE = new Locale("all", "all");
On 2010/10/14 22:23:49, mhermanto wrote:
> Ditto.

Done.

[zhoresh, 2010-10-14 23:03:42]

On 2010/10/14 22:58:35, mhermanto wrote:
> LGTM++
> 
> Talked offline. Public methods will be used externally. Name collissions are
> possible but ImmutableMap will prevent it.

Thanks, updated default locale to private and committed to r1022754