Augment &libs= for type=url gadgets

It turns out that they are used by some gadget implementations.

[johnfargo, 2010-10-13 04:59:32]

Only minor comment is that it would be nice not to break encapsulation with
DefaultJsUriManager to get the libs param value -- but I see the rationale
here, and don't feel the need to overengineer. Perhaps split the call out
into an overridable protected w/ this default impl?

On Tue, Oct 12, 2010 at 9:33 PM, <mhermanto@gmail.com> wrote:

> Reviewers: dev-remailer_shindig.apache.org,
>
> Description:
> It turns out that they are used by some gadget implementations.
>
> Please review this at http://codereview.appspot.com/2474041/
>
> Affected files:
>
> 
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
>
> 
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java
>
>
>

[mhermanto, 2010-10-13 21:15:41]

Update patch

[mhermanto, 2010-10-13 21:28:14]

Good thought. Now overridable with addExtrasForTypeUrl(). Patch re-uploaded.
PTAL.

On Tue, Oct 12, 2010 at 9:59 PM, John Hjelmstad <johnfargo@gmail.com> wrote:

> Only minor comment is that it would be nice not to break encapsulation with
> DefaultJsUriManager to get the libs param value -- but I see the rationale
> here, and don't feel the need to overengineer. Perhaps split the call out
> into an overridable protected w/ this default impl?
>
>
> On Tue, Oct 12, 2010 at 9:33 PM, <mhermanto@gmail.com> wrote:
>
>> Reviewers: dev-remailer_shindig.apache.org,
>>
>> Description:
>> It turns out that they are used by some gadget implementations.
>>
>> Please review this at http://codereview.appspot.com/2474041/
>>
>> Affected files:
>>
>> 
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
>>
>> 
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java
>>
>>
>>
>

[johnfargo, 2010-10-13 22:00:15]

LGTM

On Wed, Oct 13, 2010 at 2:28 PM, Michael Hermanto <mhermanto@gmail.com>wrote:

> Good thought. Now overridable with addExtrasForTypeUrl(). Patch
> re-uploaded. PTAL.
>
>
> On Tue, Oct 12, 2010 at 9:59 PM, John Hjelmstad <johnfargo@gmail.com>wrote:
>
>> Only minor comment is that it would be nice not to break encapsulation
>> with DefaultJsUriManager to get the libs param value -- but I see the
>> rationale here, and don't feel the need to overengineer. Perhaps split the
>> call out into an overridable protected w/ this default impl?
>>
>>
>> On Tue, Oct 12, 2010 at 9:33 PM, <mhermanto@gmail.com> wrote:
>>
>>> Reviewers: dev-remailer_shindig.apache.org,
>>>
>>> Description:
>>> It turns out that they are used by some gadget implementations.
>>>
>>> Please review this at http://codereview.appspot.com/2474041/
>>>
>>> Affected files:
>>>
>>> 
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
>>>
>>> 
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java
>>>
>>>
>>>
>>
>