Make scanner self-test omit prototypes.

test-scan-guest testScanner is unnecessarily fragile because it exposes
more ordinary object structure than just what was tested for, possibly
reacting to changes in the scan or problem reporting than what it was
looking for. Now the test object graph is run through detach(), which
reproduces the graph with no [[Prototype]]s to keep it to the explicitly
written structure.

@r5628

[kpreid2, 2013-11-11 21:58:17]

test-scan-guest testScanner is unnecessarily fragile because it exposes
more ordinary object structure than just what was tested for, possibly
reacting to changes in the scan or problem reporting than what it was
looking for. Now the test object graph is run through detach(), which
reproduces the graph with no [[Prototype]]s to keep it to the explicitly
written structure.

[kpreid2, 2013-11-11 23:19:34]

test-scan-guest testScanner is unnecessarily fragile because it exposes
more ordinary object structure than just what was tested for, possibly
reacting to changes in the scan or problem reporting than what it was
looking for. Now the test object graph is run through detach(), which
reproduces the graph with no [[Prototype]]s to keep it to the explicitly
written structure.

[felix8a, 2013-11-12 01:26:12]

lgtm modulo comment

https://codereview.appspot.com/24710043/diff/40001/tests/com/google/caja/plug...
File tests/com/google/caja/plugin/test-scan-guest.js (right):

https://codereview.appspot.com/24710043/diff/40001/tests/com/google/caja/plug...
tests/com/google/caja/plugin/test-scan-guest.js:1491: var specimen =
detach(Object.freeze({a: {}, 1: {}, '!': {}}));
the frozenness is not preserved. detach only preserves isExtensible. is that
important?

[kpreid2, 2013-11-12 01:58:35]

https://codereview.appspot.com/24710043/diff/40001/tests/com/google/caja/plug...
File tests/com/google/caja/plugin/test-scan-guest.js (right):

https://codereview.appspot.com/24710043/diff/40001/tests/com/google/caja/plug...
tests/com/google/caja/plugin/test-scan-guest.js:1491: var specimen =
detach(Object.freeze({a: {}, 1: {}, '!': {}}));
On 2013/11/12 01:26:13, felix8a wrote:
> the frozenness is not preserved. detach only preserves isExtensible. is that
> important?

It preserves frozenness because it preserves the extensible flag and the
writable and configurable flags for each property. There is no independent
frozen flag.

[felix8a, 2013-11-12 06:28:28]

On 2013/11/12 01:58:35, kpreid2 wrote:
>
https://codereview.appspot.com/24710043/diff/40001/tests/com/google/caja/plug...
> File tests/com/google/caja/plugin/test-scan-guest.js (right):
> 
>
https://codereview.appspot.com/24710043/diff/40001/tests/com/google/caja/plug...
> tests/com/google/caja/plugin/test-scan-guest.js:1491: var specimen =
> detach(Object.freeze({a: {}, 1: {}, '!': {}}));
> On 2013/11/12 01:26:13, felix8a wrote:
> > the frozenness is not preserved. detach only preserves isExtensible. is that
> > important?
> 
> It preserves frozenness because it preserves the extensible flag and the
> writable and configurable flags for each property. There is no independent
> frozen flag.

ah, right, duh. ok. still lgtm.