Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2236)

Issue 247041: code review 247041: regexp: add ReplaceAllFunc and ReplaceAllStringFunc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by adg
Modified:
11 years, 3 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

regexp: add ReplaceAllFunc and ReplaceAllStringFunc

Patch Set 1 #

Patch Set 2 : code review 247041: regexp: add ReplaceAllFunc and ReplaceAllStringFunc #

Patch Set 3 : code review 247041: regexp: add ReplaceAllFunc and ReplaceAllStringFunc #

Patch Set 4 : code review 247041: regexp: add ReplaceAllFunc and ReplaceAllStringFunc #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -2 lines) Patch
M src/pkg/regexp/all_test.go View 4 chunks +98 lines, -0 lines 1 comment Download
M src/pkg/regexp/regexp.go View 1 4 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 8
adg
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years, 3 months ago (2010-03-05 05:15:35 UTC) #1
adg
There are probably performance issues with this, unless the compiler is clever enough to inline ...
11 years, 3 months ago (2010-03-05 05:19:30 UTC) #2
r2
I'm not against it in principle - I like functions. A benchmark to see if ...
11 years, 3 months ago (2010-03-05 07:14:52 UTC) #3
adg
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years, 3 months ago (2010-03-06 22:43:16 UTC) #4
adg
I've added some tests. I'm open to suggestions as to more test cases (most test ...
11 years, 3 months ago (2010-03-06 22:49:12 UTC) #5
r2
On Mar 6, 2010, at 2:48 PM, Andrew Gerrand wrote: > I've added some tests. ...
11 years, 3 months ago (2010-03-06 23:59:40 UTC) #6
r
LGTM but please delete dregs. this is really nice. http://codereview.appspot.com/247041/diff/11001/12001 File src/pkg/regexp/all_test.go (right): http://codereview.appspot.com/247041/diff/11001/12001#newcode560 src/pkg/regexp/all_test.go:560: ...
11 years, 3 months ago (2010-03-07 00:02:09 UTC) #7
adg
11 years, 3 months ago (2010-03-07 01:41:55 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=0b7cedc4de63 ***

regexp: add ReplaceAllFunc and ReplaceAllStringFunc

R=r
CC=golang-dev
http://codereview.appspot.com/247041

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b