Issue 246390043: Fix VM regions details pane to correctly classify '/dev/ashmem/libc malloc' as 'Native heap'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 246390043: Fix VM regions details pane to correctly classify '/dev/ashmem/libc malloc' as 'Native heap' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by petrcermak

Modified:
10 years ago

Reviewers:
primiano

CC:
trace-viewer-review_googlegroups.com, perezju

Base URL:
git@github.com:google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Fix VM regions details pane to correctly classify '/dev/ashmem/libc malloc' as 'Native heap' Memory dump VM regions with '/dev/ashmem/libc malloc' were incorrectly classified as 'Android/Ashmem'. BUG=#1043,#849 R=primiano@chromium.org Committed: https://chromium.googlesource.com/external/trace-viewer/+/de556231b8966f5766cef9541bd93f1d9186b585

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -5 lines)			Patch
	M	trace_viewer/ui/analysis/memory_dump_vm_regions_details_pane.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	trace_viewer/ui/analysis/memory_dump_vm_regions_details_pane_test.html	View		2 chunks	+28 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

petrcermak

10 years ago (2015-06-23 15:47:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
de556231b8966f5766cef9541bd93f1d9186b585 (presubmit successful).

Expand All Messages | Collapse All Messages