Issue 245940043: Add generic_table_view

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 245940043: Add generic_table_view (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by nduca

Modified:
8 years, 11 months ago

Reviewers:

CC:
trace-viewer-review_googlegroups.com

Base URL:
https://github.com/google/trace-viewer.git@master

Visibility:
Public.

More Reviews

Description

Add generic_table_view This is for creating ad-hoc views of tabular data, without requiring all the goup of talking to <tv-b-ui-table>. Committed: https://chromium.googlesource.com/external/trace-viewer/+/35990f4f4d9e262ee1350b029dff4c1a01689a82

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+411 lines, -11 lines)			Patch
M	trace_viewer/base/iteration_helpers.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	trace_viewer/base/units/generic_table.html	View	1 chunk	+15 lines, -9 lines	0 comments	Download
A	trace_viewer/base/units/generic_table_view.html	View	1 chunk	+227 lines, -0 lines	0 comments	Download
A	trace_viewer/base/units/generic_table_view_test.html	View	1 chunk	+167 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

nduca

8 years, 11 months ago (2015-06-09 05:25:21 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
35990f4f4d9e262ee1350b029dff4c1a01689a82 (presubmit successful).

Expand All Messages | Collapse All Messages