Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 2448: PEP 3134 exception reporting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by Antoine Pitrou
Modified:
4 years, 9 months ago
Reviewers:
Benjamin, GvR
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : New patch including Amaury's indentation fix #

Patch Set 3 : Patch addressing Benjamin's concerns #

Patch Set 4 : Patch addressing Guido's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -128 lines) Patch
Include/traceback.h View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_raise.py View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
Lib/test/test_traceback.py View 1 3 chunks +130 lines, -6 lines 0 comments Download
Lib/traceback.py View 1 5 chunks +62 lines, -20 lines 0 comments Download
Modules/_testcapimodule.c View 1 2 chunks +21 lines, -0 lines 0 comments Download
Python/_warnings.c View 2 chunks +1 line, -2 lines 0 comments Download
Python/errors.c View 1 2 chunks +20 lines, -2 lines 0 comments Download
Python/pythonrun.c View 1 2 3 3 chunks +161 lines, -90 lines 0 comments Download
Python/traceback.c View 1 4 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 7
Benjamin
Mostly I complained about style things, since I'm not a exception or PEP 3134 expert. ...
5 years, 9 months ago #1
Antoine Pitrou
http://codereview.appspot.com/2448/diff/13/30 File Lib/test/test_traceback.py (right): http://codereview.appspot.com/2448/diff/13/30#newcode118 Line 118: class BaseExceptionReportingTests: On 2008/07/13 21:15:39, Benjamin wrote: > ...
5 years, 9 months ago #2
Benjamin
http://codereview.appspot.com/2448/diff/13/30 File Lib/test/test_traceback.py (right): http://codereview.appspot.com/2448/diff/13/30#newcode118 Line 118: class BaseExceptionReportingTests: On 2008/07/13 21:32:03, Antoine Pitrou wrote: ...
5 years, 9 months ago #3
GvR
I think it's time to check this in, before beta 2 gets released! http://codereview.appspot.com/2448/diff/37/46 File ...
5 years, 9 months ago #4
Antoine Pitrou
(sorry, I forgot to publish that comment) http://codereview.appspot.com/2448/diff/13/30 File Lib/test/test_traceback.py (right): http://codereview.appspot.com/2448/diff/13/30#newcode118 Line 118: class ...
5 years, 9 months ago #5
Benjamin
On 2008/07/14 21:17:01, Antoine Pitrou wrote: > > I'm not sure I agree with that. ...
5 years, 9 months ago #6
GvR
5 years, 9 months ago #7
You can close this, it's been submitted. :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5