Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 2443041: code review 2443041: build: fix darwin/386 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by adg
Modified:
14 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

build: fix darwin/386 build

Patch Set 1 #

Patch Set 2 : code review 2443041: build: fix darwin/386 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/Make.inc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 5 months ago (2010-10-12 00:48:22 UTC) #1
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=b725fd0ec942 *** build: fix darwin/386 build R=rsc CC=golang-dev http://codereview.appspot.com/2443041
14 years, 5 months ago (2010-10-12 00:49:09 UTC) #2
rsc
LGTM I am confused about why this is the right fix, but it's clearly equivalent ...
14 years, 5 months ago (2010-10-12 01:52:00 UTC) #3
adg
14 years, 5 months ago (2010-10-12 02:04:39 UTC) #4
On 12 October 2010 12:51, Russ Cox <rsc@golang.org> wrote:
> I am confused about why this is the right fix,
> but it's clearly equivalent to what was here before,
> and if it works, I'm happy to postpone understanding
> until the next time Apple changes something.

I started getting into debugging the root cause, but realized all I
was trying to solve is the case where you want to build darwin/amd64
tools for a darwin/386 target, which is such a tiny audience (if
anyone!) that it hardly seems worth it.

This change will come to bite us if we want to support darwin/arm, but
it's minor enough that I'm willing to live with that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b