Issue 2436042: Add null checks for CajaCssSanitizer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2436042: Add null checks for CajaCssSanitizer

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by zhoresh

Modified:
15 years, 5 months ago

Reviewers:
dev-remailer, Jasvir

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

We see NPE in our production from this code.

Patch Set 1 #

Total comments: 3

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java	View		2 chunks	+6 lines, -3 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jasvir

Please add a test case that causes the original error. LGTM http://codereview.appspot.com/2436042/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java (right): ...

15 years, 5 months ago (2010-10-14 23:34:08 UTC) #2

zhoresh

15 years, 5 months ago (2010-10-15 00:57:49 UTC) #3

Ok track down our bug case and added a test case.
Jasvir please take a look and see if a better sensitization needed.

Committed to r1022796

http://codereview.appspot.com/2436042/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java
(right):

http://codereview.appspot.com/2436042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java:229:
if (chain.node != null && (chain.node instanceof CssTree.Declaration ||
On 2010/10/14 23:34:08, jasvir wrote:
> This line is equivalent to the original - please revert.

Done.

Expand All Messages | Collapse All Messages