Passing accel container correctly when making normalized accel url

This change:
1) Passes the accel container when creating the normalized accel uri.
2) Adds the appropriate host header when fetching a resource in AccelHandler.

[anupama.dutta, 2010-10-12 03:53:26]

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
(left):

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:27:
import javax.servlet.ServletConfig;
Change unrelated to this patch? Move to a separate cleanup patch?

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManager.java
(right):

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManager.java:56:
gadget.setContext(new GadgetContext(gadget.getContext()) {
I presume that the effect of this change is to add container=accel into the
generated URI? If yes, could we add a test for this change?

[gagan.goku, 2010-10-12 09:03:30]

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
(left):

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:27:
import javax.servlet.ServletConfig;
On 2010/10/12 03:53:26, anupama.dutta wrote:
> Change unrelated to this patch? Move to a separate cleanup patch?

file reverted

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManager.java
(right):

http://codereview.appspot.com/2435041/diff/5001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManager.java:56:
gadget.setContext(new GadgetContext(gadget.getContext()) {
On 2010/10/12 03:53:26, anupama.dutta wrote:
> I presume that the effect of this change is to add container=accel into the
> generated URI? If yes, could we add a test for this change?

Done.

[anupama.dutta, 2010-10-12 09:25:11]

LGTM.

http://codereview.appspot.com/2435041/diff/11001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
(right):

http://codereview.appspot.com/2435041/diff/11001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:196:
// since we did not copy it from the httpRequest as it could be pointing to
Suggested rephrasal:
Since the Host header of httpRequest could be pointing to the shindig host (in
case of a normalized request), we do not copy the Host header as is. Instead we
explicitly set it to the authority of the resource being fetched as shown below.

[gagan.goku, 2010-10-12 09:29:19]

Thanks for the review.

http://codereview.appspot.com/2435041/diff/11001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
(right):

http://codereview.appspot.com/2435041/diff/11001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:196:
// since we did not copy it from the httpRequest as it could be pointing to
On 2010/10/12 09:25:11, anupama.dutta wrote:
> Suggested rephrasal:
> Since the Host header of httpRequest could be pointing to the shindig host (in
> case of a normalized request), we do not copy the Host header as is. Instead
we
> explicitly set it to the authority of the resource being fetched as shown
below.

Done.

[anupama.dutta, 2010-10-13 11:20:29]

LGTM.

[gagan.goku, 2010-10-15 05:11:39]

Build looks awesome.
Committed as r1022821. Thanks for the review Anupama.