Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 243130043: Enable Google Play services version checks

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dgn
Modified:
9 years, 12 months ago
Reviewers:
aurimas
Base URL:
https://chromium.googlesource.com/android_tools.git@master
Visibility:
Public.

Description

Enable Google Play services version checks Running GYP for Android builds will now run a script that validates the current version of Google Play services and notifies the user when it needs to be updated. BUG=490091

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M android_tools.gyp View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2
dgn
The goal of this is to be able to submit code relying on newer versions ...
9 years, 12 months ago (2015-07-09 15:43:46 UTC) #1
aurimas
9 years, 12 months ago (2015-07-09 16:50:28 UTC) #2
On 2015/07/09 15:43:46, dgn wrote:
> The goal of this is to be able to submit code relying on newer versions of the
> google play services (e.g. use gcm)
> 
> Once https://codereview.chromium.org/1229883002 lands, the check will be
skipped
> on bots, allowing to just update the version they download. This patch could
> then land, completing the version bump.

This is a wrong review tool for android_tools repo. Follow the instructions on
https://sites.google.com/a/google.com/clank/engineering/infrastructure-genera...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b