Issue 243130043: Enable Google Play services version checks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 243130043: Enable Google Play services version checks

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by dgn

Modified:
10 years ago

Reviewers:
aurimas

Base URL:
https://chromium.googlesource.com/android_tools.git@master

Visibility:
Public.

More Reviews

Description

Enable Google Play services version checks Running GYP for Android builds will now run a script that validates the current version of Google Play services and notifies the user when it needs to be updated. BUG=490091

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	android_tools.gyp	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dgn

The goal of this is to be able to submit code relying on newer versions ...

10 years ago (2015-07-09 15:43:46 UTC) #1

aurimas

10 years ago (2015-07-09 16:50:28 UTC) #2

On 2015/07/09 15:43:46, dgn wrote:
> The goal of this is to be able to submit code relying on newer versions of the
> google play services (e.g. use gcm)
> 
> Once https://codereview.chromium.org/1229883002 lands, the check will be
skipped
> on bots, allowing to just update the version they download. This patch could
> then land, completing the version bump.

This is a wrong review tool for android_tools repo. Follow the instructions on
https://sites.google.com/a/google.com/clank/engineering/infrastructure-genera...

Expand All Messages | Collapse All Messages