Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 243041: code review 243041: godoc: don't throw away function documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by gri
Modified:
15 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

godoc: don't throw away function documentation if there are multiple functions (for a package, type) with the same name Fixes issue 642.

Patch Set 1 #

Patch Set 2 : code review 243041: godoc: don't throw away function documentation #

Patch Set 3 : code review 243041: godoc: don't throw away function documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M src/pkg/go/doc/doc.go View 1 3 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-03-05 02:07:21 UTC) #1
rsc
LGTM thanks
15 years ago (2010-03-05 08:39:12 UTC) #2
gri
15 years ago (2010-03-05 18:14:06 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=826d0ef46512 ***

godoc: don't throw away function documentation
if there are multiple functions (for a package, type)
with the same name

Fixes issue 642.

R=rsc
CC=golang-dev
http://codereview.appspot.com/243041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b