Issue 242900043: Issues 4429 & 4430: timekeeping in Auto_change_iterator and Part_combine_iterator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 242900043: Issues 4429 & 4430: timekeeping in Auto_change_iterator and Part_combine_iterator (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Dan Eble

Modified:
10 years, 8 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

The timekeeping code in these iterators seemed unnecessarily complex, and in fact removing fixes problems related to grace notes (issue 4429). The missing start-callback of UnrelativableMusic was causing the abort of issue 4430.

Patch Set 1 #

Patch Set 2 : fixes and regtests #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -15 lines)			Patch
A	input/regression/autochange-inside-grace.ly	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	input/regression/autochange-with-grace.ly	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	input/regression/part-combine-inside-grace.ly	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	input/regression/part-combine-with-grace.ly	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	lily/auto-change-iterator.cc	View	1	3 chunks	+1 line, -6 lines	0 comments	Download
M	lily/part-combine-iterator.cc	View	1	3 chunks	+1 line, -9 lines	0 comments	Download
M	scm/define-music-types.scm	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fixes and regtests

Expand All Messages | Collapse All Messages