Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3050)

Issue 242580043: Release 1.5.11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by fujiwara
Modified:
8 years, 9 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Release 1.5.11 Committed: 8d5640669a72a551f2b47521c9b945c0a3ae9057

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Fix a build error. #

Patch Set 4 : Updated with the laster master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M bindings/vala/Makefile.am View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M configure.ac View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
fujiwara
8 years, 10 months ago (2015-06-24 07:39:06 UTC) #1
Peng
lgtm with a comment https://codereview.appspot.com/242580043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/242580043/diff/1/configure.ac#newcode42 configure.ac:42: [http://code.google.com/p/ibus/issues/entry], Should we change this ...
8 years, 10 months ago (2015-06-24 16:18:32 UTC) #2
fujiwara
https://codereview.appspot.com/242580043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/242580043/diff/1/configure.ac#newcode42 configure.ac:42: [http://code.google.com/p/ibus/issues/entry], On 2015/06/24 16:18:32, Peng wrote: > Should we ...
8 years, 10 months ago (2015-06-25 10:38:28 UTC) #3
fujiwara
8 years, 9 months ago (2015-07-16 05:13:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
8d5640669a72a551f2b47521c9b945c0a3ae9057 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b