Issue 242140043: Support vertical writing with IBUS_INPUT_HINT_VERTICAL_WRITING

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 242140043: Support vertical writing with IBUS_INPUT_HINT_VERTICAL_WRITING (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by fujiwara

Modified:
8 years, 10 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Support vertical writing with IBUS_INPUT_HINT_VERTICAL_WRITING GTK_INPUT_HINT_VERTICAL_WRITING has been supported in gtk 3.18 Put the vertical lookup table at the left top of the cursor position in case of the vertical mode. Also the gtk client tries to get the character width not to overlap the character when the client window is moved to the screen left. BUG=https://code.google.com/p/ibus/issues/detail?id=1780 Committed: 7fd6077f19a5a39cdcd9c7fde0d9c8234ae5592e

Patch Set 1 #

Patch Set 2 : Use cursor height instead of getting char size. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -10 lines)			Patch
M	src/ibustypes.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/gtk3/candidatearea.vala	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	ui/gtk3/candidatepanel.vala	View	1	9 chunks	+82 lines, -7 lines	0 comments	Download
M	ui/gtk3/panel.vala	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fujiwara

Revised the patch not to calculate the pango char width in im module.

8 years, 10 months ago (2015-06-12 04:53:31 UTC) #3

fujiwara

8 years, 10 months ago (2015-06-15 02:19:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7fd6077f19a5a39cdcd9c7fde0d9c8234ae5592e (presubmit successful).

Expand All Messages | Collapse All Messages