Issue 242110043: Let Input::error actually raise a fatal error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 242110043: Let Input::error actually raise a fatal error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by dak

Modified:
8 years, 10 months ago

Reviewers:
Dan Eble

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Let Input::error actually raise a fatal error Use Input::non_fatal_error instead of Input::error where appropriate

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -15 lines)			Patch
M	lily/input.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	lily/lily-lexer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/lily-parser.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lily/parse-scm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lily/score.cc	View	1 chunk	+10 lines, -8 lines	0 comments	Download

Total messages: 1

Dan Eble

8 years, 10 months ago (2015-06-11 11:49:38 UTC) #1

I'm not familiar with this area of the code, but I reviewed the change and it
raises no alarms, so LGTM.