Issue 241980043: Add MinGW support of scale-down-image (ps-to-png.scm)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 241980043: Add MinGW support of scale-down-image (ps-to-png.scm)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by trueroad

Modified:
8 years, 10 months ago

Reviewers:
pkx166h

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Add MinGW support of scale-down-image (ps-to-png.scm) scale-down-image can work on MinGW by this commit. Add Netpbm commands search procedures pngtopnm is obsoleted by pngtopam. pnmscale is obsoleted by pamscale. Add ly:system-with-shell for pipe and redirection handling ly:system can't handle pipe and redirection. This procedure can handle them by using shell. It also works on MinGW by switching shell. Delete duplicate and unused procedures in ps-to-png.scm backend-library.scm: sanitize-command-option: unused ps-to-png.scm: _: lily.scm my-system: unused

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -30 lines)			Patch
	M	scm/backend-library.scm	View		1 chunk	+23 lines, -7 lines	0 comments	Download
	M	scm/ps-to-png.scm	View		2 chunks	+25 lines, -23 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

trueroad

8 years, 10 months ago (2015-06-14 14:22:47 UTC) #2

I've pushed to staging.

 Issue 4431  / 4: Add MinGW support of scale-down-image (ps-to-png.scm)
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 1 Jun 2015 13:18:22 +0000 (22:18 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Sun, 14 Jun 2015 13:36:29 +0000 (22:36 +0900)
commit    e54464202c43ce23cd5667a2e42aca0905efb44e

 Issue 4431  / 3: Add Netpbm commands search procedures
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 1 Jun 2015 13:15:09 +0000 (22:15 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Sun, 14 Jun 2015 13:36:29 +0000 (22:36 +0900)
commit    1585dd6c7b781e9f91490eb463b4aa96610b66fd

 Issue 4431  / 2: Add ly:system-with-shell for pipe and redirection handling
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 1 Jun 2015 13:12:49 +0000 (22:12 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Sun, 14 Jun 2015 13:36:29 +0000 (22:36 +0900)
commit    c50743b786e68dfd298ffbe7ee2c01e794ac9fda

 Issue 4431  / 1: Delete duplicate and unused procedures in ps-to-png.scm
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 1 Jun 2015 13:05:47 +0000 (22:05 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Sun, 14 Jun 2015 13:36:28 +0000 (22:36 +0900)
commit    0091371dea0a375b41fcd6916085aa8ad102c759

Expand All Messages | Collapse All Messages