Issue 241880043: Update Android samples for Android Studio 1.2.1.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 241880043: Update Android samples for Android Studio 1.2.1.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by nherring

Modified:
9 years, 10 months ago

Reviewers:
wonderfly, ejona

CC:
ekoleda+devrel

Base URL:
https://github.com/google/google-api-java-client-samples

Visibility:
Public.

More Reviews

Description

Update Android samples for Android Studio 1.2.1.1

Patch Set 2 : Google Play Services version in metadata #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -34 lines)			Patch
M	.gitignore	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	build.gradle	View		1 chunk	+1 line, -1 line	0 comments	Download
M	calendar-android-sample/AndroidManifest.xml	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	calendar-android-sample/build.gradle	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	calendar-android-sample/instructions.html	View		5 chunks	+13 lines, -10 lines	0 comments	Download
M	tasks-android-sample/AndroidManifest.xml	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tasks-android-sample/build.gradle	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	tasks-android-sample/instructions.html	View		7 chunks	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

nherring

https://codereview.appspot.com/241880043/diff/1/calendar-android-sample/AndroidManifest.xml File calendar-android-sample/AndroidManifest.xml (right): https://codereview.appspot.com/241880043/diff/1/calendar-android-sample/AndroidManifest.xml#newcode34 calendar-android-sample/AndroidManifest.xml:34: android:value="@integer/google_play_services_version" /> According to http://developer.android.com/google/play-services/setup.html, this isn't necessary if ...

9 years, 11 months ago (2015-05-28 14:52:04 UTC) #2

nherring

Adding some representatives from the Calender team whose samples these are.

9 years, 11 months ago (2015-05-29 16:20:21 UTC) #4

ejona

9 years, 10 months ago (2015-06-03 21:02:23 UTC) #7

This patch is committed now:
https://github.com/google/google-api-java-client-samples/commit/12cb7b9a187ff...

You can close this issue now.

Expand All Messages | Collapse All Messages