Issue 241640043: Rev 2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 241640043: Rev 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by ekr-rietveld

Modified:
10 years, 2 months ago

Reviewers:
mt

Visibility:
Public.

More Reviews

Description

Rev 2

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -1 line)			Patch
M	external_tests/ssl_gtest/ssl_skip_unittest.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	external_tests/ssl_gtest/tls_agent.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	external_tests/ssl_gtest/tls_agent.cc	View	1 chunk	+17 lines, -0 lines	1 comment	Download
M	external_tests/ssl_gtest/tls_connect.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	external_tests/ssl_gtest/tls_connect.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

10 years, 2 months ago (2015-06-24 18:28:52 UTC) #3

Message was sent while issue was closed.

r+

https://codereview.appspot.com/241640043/diff/1/external_tests/ssl_gtest/tls_...
File external_tests/ssl_gtest/tls_agent.cc (right):

https://codereview.appspot.com/241640043/diff/1/external_tests/ssl_gtest/tls_...
external_tests/ssl_gtest/tls_agent.cc:100: for (size_t i=0; i <
PR_ARRAY_SIZE(dheCiphers); ++i) {
Nit: i = 0

Expand All Messages | Collapse All Messages