code review 241041: gofmt: modified algorithm for alignment of multi-line c...

gofmt: modified algorithm for alignment of multi-line composite/list entries
- only manual changes are in src/pkg/go/printer/nodes.go
- use a heuristic to determine "outliers" such that not entire composites are
  forced to align with them
- improves several places that were not unligned before due too simple heuristic
- unalignes some cases that contain "outliers"
- gofmt -w src misc

Fixes issue 644.

[gri, 2010-03-05 00:35:14]

Hello rsc, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-03-05 00:56:55]

I'm not sure.  These look awkward:

http://codereview.appspot.com/241041/diff/2001/3005?context=10&column_width=80
http://codereview.appspot.com/241041/diff/2001/3018?context=10&column_width=80
http://codereview.appspot.com/241041/diff/2001/3007?context=10&column_width=80

The old rule was very easy to understand.
This one seems pretty unpredictable.

Russ

[gri, 2010-03-05 01:10:28]

PTAL.

Changed the line size ratio from 2 to 4 - this leaves existing alignment
untouched, still fixes a few broken cases, and prevents huge outliers from
screwing things up. Some files in the CL may have no changes anymore.

- Robert

On Thu, Mar 4, 2010 at 4:56 PM, Russ Cox <rsc@golang.org> wrote:

> I'm not sure.  These look awkward:
>
>
> http://codereview.appspot.com/241041/diff/2001/3005?context=10&column_width=80
>
> http://codereview.appspot.com/241041/diff/2001/3018?context=10&column_width=80
>
> http://codereview.appspot.com/241041/diff/2001/3007?context=10&column_width=80
>
> The old rule was very easy to understand.
> This one seems pretty unpredictable.
>
> Russ
>

[rsc, 2010-03-05 01:15:57]

LGTM

looks much better

[r2, 2010-03-05 01:20:52]

LGTM

[gri, 2010-03-05 01:37:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=b149459ad2ff ***

gofmt: modified algorithm for alignment of multi-line composite/list entries
- only manual changes are in src/pkg/go/printer/nodes.go
- use a heuristic to determine "outliers" such that not entire composites are
  forced to align with them
- improves several places that were not unligned before due too simple heuristic
- unalignes some cases that contain "outliers"
- gofmt -w src misc

Fixes issue 644.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/241041