code review 240960043: power64asm: add plan9Syntax output for Go objdump

power64asm: add plan9Syntax output for Go objdump

[minux, 2015-05-26 22:16:49]

Hello rsc@golang.org,

I'd like you to review this change to
https://code.google.com/p/rsc.power64/

[minux, 2015-05-26 22:19:14]

After this CL and CL 232680043 (trivial) are reviewed and submitted,
we can rename power64 to ppc64 and redo the hg2git conversion
for rsc.io/ppc64.

[rsc, 2015-05-26 23:48:42]

please resend the CLs using git. rietveld works with git too. i'd rather
not redo the hg2git conversion. what if people have it checked out already?

thanks.
russ


On Tue, May 26, 2015 at 6:18 PM, minux <minux@golang.org> wrote:

> After this CL and CL 232680043 (trivial) are reviewed and submitted,
> we can rename power64 to ppc64 and redo the hg2git conversion
> for rsc.io/ppc64.
>

[minux, 2015-05-26 23:59:15]

On Tue, May 26, 2015 at 7:48 PM, Russ Cox <rsc@golang.org> wrote:

> please resend the CLs using git. rietveld works with git too. i'd rather
> not redo the hg2git conversion. what if people have it checked out already?
>

the git repository only contains two commits, which means I have
to send a big CL with all the old changes and that will also destroy
commit history.

If invaliding the existing commit hashes is your only concern, I can
do the hg2git conversion so that we keep the existing commit hashes
and rewrite the filenames as well in one run.

[rsc, 2015-05-27 15:58:45]

sorry, i thought it was in better shape. i will take a look later.

[minux, 2015-05-27 20:34:11]

On May 27, 2015 11:58 AM, "Russ Cox" <rsc@golang.org> wrote:
> sorry, i thought it was in better shape. i will take a look later.

I can convert the hg repo if you're busy with other stuff. (I can send you
a diff of git fast-import that you could review and also reproduce the
conversion exactly together with a regular fast-import output of hg2git
conversion.)

And since we have to convert again anyway, could we do the code review in
the old hg repo? Adding two more commits won't make the conversion any
harder.

Thanks.

[rsc, 2015-06-26 18:51:58]

LGTM