Issue 24070: Fixes a bug in BufferingRender which in turn corrects an error in JsPrettyPrinter used by Shindig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 24070: Fixes a bug in BufferingRender which in turn corrects an error in JsPrettyPrinter used by Shindig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 1 month ago by Jasvir

Modified:
16 years, 8 months ago

Reviewers:
Ben Laurie (Google)

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

* FilePosition should be compared to another FilePosition not InputSource @3343

Created: 17 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/com/google/caja/render/BufferingRenderer.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/com/google/caja/reporting/MessagePart.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

Jasvir

Corrects one more place where we make a type error on equals. I ran FindBugs ...

17 years, 1 month ago (2009-03-06 17:59:12 UTC) #3

LGTM