ibus-ui-gtk3: radio and check menu items work with GTK 3.16

ibus-ui-gtk3: radio and check menu items work with GTK 3.16

GTK 3.16 has cleared the radio buttons' state in
gtk_radio_menu_item_set_group():
https://git.gnome.org/browse/gtk+/commit/?id=955aed9227

BUG=https://code.google.com/p/ibus/issues/detail?id=1784
TEST=ui/gtk3/ibus-ui-gtk3

[Peng, 2015-05-22 03:23:59]

https://codereview.appspot.com/240100043/diff/1/ui/gtk3/property.vala
File ui/gtk3/property.vala (right):

https://codereview.appspot.com/240100043/diff/1/ui/gtk3/property.vala#newcode193
ui/gtk3/property.vala:193: public void update_property(IBus.Property property) {
Seems those function implementations are similar to functions in
PropCheckMenuItem. Can PropCheckMenuItem and PropRadioMenuItem share one parent
class to avoid duplicate code?

For example:

class PropItem : IPropItem {
 void update_propertu(...) { ... }
 ...
}
class PropRadioMenuItem : Gtk.RadioMenuItem, PropRadioItem {}
class PropCheckMenuItem : Gtk.RadioMenuItem, PropRadioItem {}

[fujiwara, 2015-05-22 04:57:35]

https://codereview.appspot.com/240100043/diff/1/ui/gtk3/property.vala
File ui/gtk3/property.vala (right):

https://codereview.appspot.com/240100043/diff/1/ui/gtk3/property.vala#newcode193
ui/gtk3/property.vala:193: public void update_property(IBus.Property property) {
On 2015/05/22 03:23:59, Peng wrote:
> Seems those function implementations are similar to functions in
> PropCheckMenuItem. Can PropCheckMenuItem and PropRadioMenuItem share one
parent
> class to avoid duplicate code?
> 
> For example:
> 
> class PropItem : IPropItem {
>  void update_propertu(...) { ... }
>  ...
> }
> class PropRadioMenuItem : Gtk.RadioMenuItem, PropRadioItem {}
> class PropCheckMenuItem : Gtk.RadioMenuItem, PropRadioItem {}

I think the PropCheckItem class can have only update_property() because sync()
and toggled() uses GTK APIs internally.
E.g. set_label() in sync() is a GTK API.
E.g. get_active() in toggled() is a GTK API.
And also need to create a new method in PropCheckItem.
E.g. set_property_label(label) calls m_property.set_label(label) internally.

So I don't think this way avoid the duplicated codes?

[Peng, 2015-05-22 10:32:56]

lgtm

https://codereview.appspot.com/240100043/diff/1/ui/gtk3/property.vala
File ui/gtk3/property.vala (right):

https://codereview.appspot.com/240100043/diff/1/ui/gtk3/property.vala#newcode193
ui/gtk3/property.vala:193: public void update_property(IBus.Property property) {
On 2015/05/22 04:57:35, fujiwara wrote:
> On 2015/05/22 03:23:59, Peng wrote:
> > Seems those function implementations are similar to functions in
> > PropCheckMenuItem. Can PropCheckMenuItem and PropRadioMenuItem share one
> parent
> > class to avoid duplicate code?
> > 
> > For example:
> > 
> > class PropItem : IPropItem {
> >  void update_propertu(...) { ... }
> >  ...
> > }
> > class PropRadioMenuItem : Gtk.RadioMenuItem, PropRadioItem {}
> > class PropCheckMenuItem : Gtk.RadioMenuItem, PropRadioItem {}
> 
> I think the PropCheckItem class can have only update_property() because sync()
> and toggled() uses GTK APIs internally.
> E.g. set_label() in sync() is a GTK API.
> E.g. get_active() in toggled() is a GTK API.
> And also need to create a new method in PropCheckItem.
> E.g. set_property_label(label) calls m_property.set_label(label) internally.
> 
> So I don't think this way avoid the duplicated codes?

I see.