Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 239041: Got javascript: URIs working (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 3 months ago by MikeSamuel
Modified:
16 years, 3 months ago
Reviewers:
Jasvir, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Made some minor changes to plugin_dispatchEvent___ since code in javascript: URI does not have this or event bound differently than top level script code. Updated HtmlAttributeRewriter to use the new dispatch method, and to store the handler someplace where the dispatch method can get at it since href values are strings, while the setAttr for onclick handlers takes a function instance as a value. Modified bridal to workaround Firefox which runs javascript: URLs in the frame specified by target. Submitted @4031

Patch Set 1 #

Total comments: 2

Patch Set 2 : Got javascript: URIs working #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -64 lines) Patch
M src/com/google/caja/demos/playground/client/ui/PlaygroundView.java View 1 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/bridal.js View 1 1 chunk +30 lines, -9 lines 0 comments Download
M src/com/google/caja/plugin/domita.js View 1 3 chunks +18 lines, -17 lines 0 comments Download
M src/com/google/caja/plugin/templates/HtmlAttributeRewriter.java View 1 4 chunks +17 lines, -13 lines 0 comments Download
M src/com/google/caja/plugin/templates/SafeHtmlMaker.java View 5 chunks +16 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 2 chunks +10 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/templates/TemplateCompilerTest.java View 1 4 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 5
MikeSamuel
16 years, 3 months ago (2010-03-04 23:44:31 UTC) #1
Jasvir
LGTM http://codereview.appspot.com/239041/diff/1/4 File src/com/google/caja/plugin/domita.js (right): http://codereview.appspot.com/239041/diff/1/4#newcode4145 src/com/google/caja/plugin/domita.js:4145: || imports[handler]; imports.handler is always readable?
16 years, 3 months ago (2010-03-09 01:58:01 UTC) #2
MikeSamuel
http://codereview.appspot.com/239041/diff/1/4 File src/com/google/caja/plugin/domita.js (right): http://codereview.appspot.com/239041/diff/1/4#newcode4145 src/com/google/caja/plugin/domita.js:4145: || imports[handler]; On 2010/03/09 01:58:01, jasvir wrote: > imports.handler ...
16 years, 3 months ago (2010-03-09 03:48:46 UTC) #3
MikeSamuel
ping
16 years, 3 months ago (2010-03-12 22:27:28 UTC) #4
MikeSamuel
16 years, 3 months ago (2010-03-16 00:40:26 UTC) #5
ping
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b