Make generic_object_view use table builder

Make generic_object_view use table builder.

BUG=
R=nduca@chromium.org

Committed: https://chromium.googlesource.com/external/trace-viewer/+/baad499fa8abde62b04a9c8bb96c106745822843

[nduca, 2015-05-28 23:12:49]

nearly lgt

https://codereview.appspot.com/238620043/diff/1/trace_viewer/core/analysis/ge...
File trace_viewer/core/analysis/generic_object_view_test.html (right):

https://codereview.appspot.com/238620043/diff/1/trace_viewer/core/analysis/ge...
trace_viewer/core/analysis/generic_object_view_test.html:154:
assert.equal('col0', table.rows[0].children[0].children[0].cellTitle);
here i'd suggest finding the table and then just checking that tableRows and
tableColumns were set up properly. RIght now you're overtesting and testing
whether the table builder is working. You want to stop a unit test at its "unit
boundaries" if that makes sense?

[benjhayden, 2015-05-29 17:34:36]

https://codereview.appspot.com/238620043/diff/1/trace_viewer/core/analysis/ge...
File trace_viewer/core/analysis/generic_object_view_test.html (right):

https://codereview.appspot.com/238620043/diff/1/trace_viewer/core/analysis/ge...
trace_viewer/core/analysis/generic_object_view_test.html:154:
assert.equal('col0', table.rows[0].children[0].children[0].cellTitle);
On 2015/05/28 23:12:49, nduca wrote:
> here i'd suggest finding the table and then just checking that tableRows and
> tableColumns were set up properly. RIght now you're overtesting and testing
> whether the table builder is working. You want to stop a unit test at its
"unit
> boundaries" if that makes sense?

Done.

[nduca, 2015-06-03 03:38:32]

probably needs rebase given that i renamed some of this stuff

[nduca, 2015-06-03 03:38:36]

lgtm

[benjhayden, 2015-06-03 23:04:39]

Committed patchset #3 (id:40001) manually as
baad499fa8abde62b04a9c8bb96c106745822843 (presubmit successful).