Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1718)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
238170044
: Changes to source scanner helper and examples. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by
Joachim Metz
Modified:
10 years, 4 months ago
Reviewers:
kiddi
,
onager
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.
More Reviews
Description
Changes to source scanner helper and examples.
Patch Set 1
#
Patch Set 2 : Code updated.
#
Patch Set 3 : Submitted.
#
Created:
10 years, 4 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+969 lines, -137 lines
)
Patch
M
config/dpkg/changelog
View
1
2
1 chunk
+2 lines, -2 lines
0 comments
Download
M
dfvfs/__init__.py
View
1
2
1 chunk
+1 line, -1 line
0 comments
Download
M
dfvfs/helpers/source_scanner.py
View
15 chunks
+124 lines, -41 lines
0 comments
Download
M
dfvfs/lib/definitions.py
View
1 chunk
+14 lines, -0 lines
0 comments
Download
A
examples/list_file_entries.py
View
1
1 chunk
+413 lines, -0 lines
0 comments
Download
M
examples/recursive_hasher.py
View
1
10 chunks
+77 lines, -43 lines
0 comments
Download
M
examples/recursive_hasher2.py
View
1
12 chunks
+85 lines, -50 lines
0 comments
Download
A
examples/source_analyzer.py
View
1 chunk
+253 lines, -0 lines
0 comments
Download
Messages
Total messages: 4
Expand All Messages
|
Collapse All Messages
Joachim Metz
10 years, 4 months ago (2015-05-14 10:37:59 UTC)
#1
Sign in
to reply to this message.
Joachim Metz
Code updated.
10 years, 4 months ago (2015-05-14 11:00:24 UTC)
#2
Code updated.
Sign in
to reply to this message.
kiddi
LGTM
10 years, 4 months ago (2015-05-14 11:26:46 UTC)
#3
LGTM
Sign in
to reply to this message.
Joachim Metz
Code Submitted.
10 years, 4 months ago (2015-05-14 11:34:40 UTC)
#4
Code Submitted.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 238170044: Changes to source scanner helper and examples. (Closed)
Created 10 years, 4 months ago by Joachim Metz
Modified 10 years, 4 months ago
Reviewers: kiddi, onager
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b