code review 238042: install.html: add section on C tools

install.html: add section on C tools

[gri, 2010-03-06 00:32:28]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-03-06 00:43:01]

This text is already a few lines down, no?

On Fri, Mar 5, 2010 at 16:32,  <gri@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> install.html: added OS X requirement hint
>
> Please review this at http://codereview.appspot.com/238042/show
>
> Affected files:
>  M doc/install.html
>
>
> Index: doc/install.html
> ===================================================================
> --- a/doc/install.html
> +++ b/doc/install.html
> @@ -185,9 +185,12 @@
>  $ sudo easy_install mercurial
>  </pre>
>
> -<p>works on most systems.
> -(On Ubuntu/Debian, you might try <code>apt-get install python-setuptools
> python-dev build-essential gcc</code> first.)
> -If that fails, visit the <a
> href="http://mercurial.selenic.com/wiki/Download">Mercurial Download</a>
> page.</p>
> +<p>works on most systems. (On OS X, make sure you have gcc installed, for
> instance as part of
> +<a
> href="http://developer.apple.com/technologies/tools/xcode.html">XCode</a>.
> +On Ubuntu/Debian, you might try <code>apt-get install python-setuptools
> python-dev build-essential gcc</code> first.)
> +If that fails, visit the <a
> href="http://mercurial.selenic.com/wiki/Download">Mercurial Download</a>
> page.
> +<p>
> +
>
>  <p>Make sure the <code>$GOROOT</code> directory does not exist or is empty.
>  Then check out the repository:</p>
>
>
>

[gri, 2010-03-06 01:04:33]

I see. Perhaps it should move up since sudo easy_install mercurial complained
about not having gcc.
- Robert

On Fri, Mar 5, 2010 at 4:42 PM, Russ Cox <rsc@golang.org> wrote:

> This text is already a few lines down, no?
>
> On Fri, Mar 5, 2010 at 16:32,  <gri@golang.org> wrote:
> > Reviewers: rsc,
> >
> > Message:
> > Hello rsc (cc: golang-dev@googlegroups.com),
> >
> > I'd like you to review this change.
> >
> >
> > Description:
> > install.html: added OS X requirement hint
> >
> > Please review this at http://codereview.appspot.com/238042/show
> >
> > Affected files:
> >  M doc/install.html
> >
> >
> > Index: doc/install.html
> > ===================================================================
> > --- a/doc/install.html
> > +++ b/doc/install.html
> > @@ -185,9 +185,12 @@
> >  $ sudo easy_install mercurial
> >  </pre>
> >
> > -<p>works on most systems.
> > -(On Ubuntu/Debian, you might try <code>apt-get install python-setuptools
> > python-dev build-essential gcc</code> first.)
> > -If that fails, visit the <a
> > href="http://mercurial.selenic.com/wiki/Download">Mercurial Download</a>
> > page.</p>
> > +<p>works on most systems. (On OS X, make sure you have gcc installed,
> for
> > instance as part of
> > +<a
> > href="http://developer.apple.com/technologies/tools/xcode.html
> ">XCode</a>.
> > +On Ubuntu/Debian, you might try <code>apt-get install python-setuptools
> > python-dev build-essential gcc</code> first.)
> > +If that fails, visit the <a
> > href="http://mercurial.selenic.com/wiki/Download">Mercurial Download</a>
> > page.
> > +<p>
> > +
> >
> >  <p>Make sure the <code>$GOROOT</code> directory does not exist or is
> empty.
> >  Then check out the repository:</p>
> >
> >
> >
>

[rsc, 2010-03-06 01:08:04]

sure

On Fri, Mar 5, 2010 at 17:04, Robert Griesemer <gri@golang.org> wrote:
> I see. Perhaps it should move up since sudo easy_install
> mercurial complained about not having gcc.
> - Robert
>
> On Fri, Mar 5, 2010 at 4:42 PM, Russ Cox <rsc@golang.org> wrote:
>>
>> This text is already a few lines down, no?
>>
>> On Fri, Mar 5, 2010 at 16:32,  <gri@golang.org> wrote:
>> > Reviewers: rsc,
>> >
>> > Message:
>> > Hello rsc (cc: golang-dev@googlegroups.com),
>> >
>> > I'd like you to review this change.
>> >
>> >
>> > Description:
>> > install.html: added OS X requirement hint
>> >
>> > Please review this at http://codereview.appspot.com/238042/show
>> >
>> > Affected files:
>> >  M doc/install.html
>> >
>> >
>> > Index: doc/install.html
>> > ===================================================================
>> > --- a/doc/install.html
>> > +++ b/doc/install.html
>> > @@ -185,9 +185,12 @@
>> >  $ sudo easy_install mercurial
>> >  </pre>
>> >
>> > -<p>works on most systems.
>> > -(On Ubuntu/Debian, you might try <code>apt-get install
>> > python-setuptools
>> > python-dev build-essential gcc</code> first.)
>> > -If that fails, visit the <a
>> > href="http://mercurial.selenic.com/wiki/Download">Mercurial Download</a>
>> > page.</p>
>> > +<p>works on most systems. (On OS X, make sure you have gcc installed,
>> > for
>> > instance as part of
>> > +<a
>> >
>> > href="http://developer.apple.com/technologies/tools/xcode.html">XCode</a>.
>> > +On Ubuntu/Debian, you might try <code>apt-get install python-setuptools
>> > python-dev build-essential gcc</code> first.)
>> > +If that fails, visit the <a
>> > href="http://mercurial.selenic.com/wiki/Download">Mercurial Download</a>
>> > page.
>> > +<p>
>> > +
>> >
>> >  <p>Make sure the <code>$GOROOT</code> directory does not exist or is
>> > empty.
>> >  Then check out the repository:</p>
>> >
>> >
>> >
>
>

[gri, 2010-03-10 23:49:43]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-03-10 23:55:43]

http://codereview.appspot.com/238042/diff/5001/6001
File doc/install.html (right):

http://codereview.appspot.com/238042/diff/5001/6001#newcode188
doc/install.html:188: <p>works on most systems. (On OS X, if run the first time,
this may require gcc, see also below in "Install Go".
Linux needs gcc before easy_install too.
It probably makes sense to make a new <h2> section above this one
named <h2>Install C tools, if needed</h2> that has the first paragraph from
Install Go.

http://codereview.appspot.com/238042/diff/5001/6001#newcode191
doc/install.html:191: <p>
</p>
(missing /)

[gri, 2010-03-11 00:07:27]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-03-11 00:17:13]

LGTM

[gri, 2010-03-11 00:31:12]

*** Submitted as http://code.google.com/p/go/source/detail?r=7003e21eb053 ***

install.html: add section on C tools

R=rsc
CC=golang-dev
http://codereview.appspot.com/238042