Issue 2380042: code review 2380042: crypto/tls: better error messages for certificate issues.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2380042: code review 2380042: crypto/tls: better error messages for certificate issues. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by agl

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, agl1, golang-dev

Visibility:
Public.

Description

crypto/tls: better error messages for certificate issues. Fixes issue 1146.

Patch Set 1 #

Patch Set 2 : code review 2380042: crypto/tls: better error messages for certificate issues. #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -11 lines)			Patch
M	src/pkg/crypto/tls/handshake_client.go	View	4 chunks	+13 lines, -7 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server.go	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/pkg/crypto/tls/tls.go	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

The bug report correctly points out the certificate errors (the most common issue that people ...

14 years, 5 months ago (2010-10-08 17:57:36 UTC) #1

agl

Hello rsc, agl1 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-10-11 14:39:54 UTC) #3

agl

14 years, 5 months ago (2010-10-11 14:40:28 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=0ba3755284fc ***

	crypto/tls: better error messages for certificate issues.

        Fixes issue 1146.

R=rsc, agl1
CC=golang-dev
http://codereview.appspot.com/2380042

Expand All Messages | Collapse All Messages