Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1663)

Issue 238000043: ticket:11674: Make ULocale work better with Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by roubert (google)
Modified:
9 years, 8 months ago
Reviewers:
markus.icu
Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk
Visibility:
Public.

Description

ticket:11674: Make ULocale work better with Android. Android supports scripts and Unicode extensions, but not locale categories. Instead of identifying Java version to determine capabilities, this change introduces two booleans in JDKLocaleHelper, one that tells whether the implementation supports locale categories, and another that tells whether scripts and extensions are supported. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/37430

Patch Set 1 #

Patch Set 2 : Split try-catch block. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M main/classes/core/src/com/ibm/icu/util/ULocale.java View 1 10 chunks +23 lines, -13 lines 0 comments Download

Messages

Total messages: 4
markus.icu
This looks mostly good to me, except: It would be much cleaner to break the ...
9 years, 8 months ago (2015-05-07 18:28:22 UTC) #1
roubert (google)
On 2015/05/07 18:28:22, markus.icu wrote: > It would be much cleaner to break the one ...
9 years, 8 months ago (2015-05-08 11:04:30 UTC) #2
markus.icu
LGTM Please commit to trunk.
9 years, 8 months ago (2015-05-08 14:43:12 UTC) #3
roubert (google)
9 years, 8 months ago (2015-05-08 14:43:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 37430 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b