Issue 2365044: code review 2365044: gc: elide dead code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2365044: code review 2365044: gc: elide dead code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rsc

Modified:
14 years, 7 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: elide dead code

Patch Set 1 #

Patch Set 2 : code review 2365044: gc: elide dead code #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	src/cmd/gc/gen.c	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-10-07 08:42:25 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=1453b35709de *** gc: elide dead code R=ken2 CC=golang-dev http://codereview.appspot.com/2365044

14 years, 7 months ago (2010-10-07 08:42:32 UTC) #2

ken3

i think this is a mistake. can get into the code with goto.

14 years, 7 months ago (2010-10-07 10:23:46 UTC) #3

rsc

14 years, 7 months ago (2010-10-07 10:35:51 UTC) #4

ah yes.  will fix.

On Thu, Oct 7, 2010 at 06:23,  <ken@google.com> wrote:
>
> i think this is a mistake.
> can get into the code with goto.
>
>
> http://codereview.appspot.com/2365044/
>

Expand All Messages | Collapse All Messages