Issue 236410043: Enable null return in gobject-introspection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 236410043: Enable null return in gobject-introspection (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by fujiwara

Modified:
9 years, 6 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Enable null return in gobject-introspection TEST=src/IBus.gir bindings/vala/ibus.vapi

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -28 lines)			Patch
M	engine/main.vala	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ibusfactory.c	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ibusservice.h	View	4 chunks	+45 lines, -2 lines	0 comments	Download
M	ui/gtk3/indicator.vala	View	3 chunks	+23 lines, -23 lines	0 comments	Download

Total messages: 2

On 2015/05/21 02:49:10, fujiwara wrote:

lgtm