Issue 2355042: Improve speed for ir.property and reference fields for issue1623 and issue1631

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2355042: Improve speed for ir.property and reference fields for issue1623 and issue1631 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by ced

Modified:
15 years, 4 months ago

Reviewers:
bch, yangoon1

Visibility:
Public.

Patch Set 2 : Fix when res_ids is None #

Total comments: 2

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -77 lines)			Patch
M	trytond/ir/model.py	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	trytond/ir/property.py	View	1	8 chunks	+38 lines, -63 lines	2 comments	Download
M	trytond/model/fields/reference.py	View		4 chunks	+23 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bch

http://codereview.appspot.com/2355042/diff/3001/trytond/ir/property.py File trytond/ir/property.py (left): http://codereview.appspot.com/2355042/diff/3001/trytond/ir/property.py#oldcode133 trytond/ir/property.py:133: res[field.name][res_id] = False Why this part is removed? (or ...

15 years, 4 months ago (2010-10-03 19:57:43 UTC) #4

ced

15 years, 4 months ago (2010-10-03 20:40:27 UTC) #5

http://codereview.appspot.com/2355042/diff/3001/trytond/ir/property.py
File trytond/ir/property.py (left):

http://codereview.appspot.com/2355042/diff/3001/trytond/ir/property.py#oldcod...
trytond/ir/property.py:133: res[field.name][res_id] = False
On 2010/10/03 19:57:43, bch wrote:
> Why this part is removed? (or why was it needed in the first place ?).
Because it is already managed by the Reference field.

Expand All Messages | Collapse All Messages