Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2540)

Issue 235430043: ticket:11674: Make ULocale tests work better with Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by roubert (google)
Modified:
9 years, 6 months ago
Reviewers:
markus.icu
Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk
Visibility:
Public.

Description

ticket:11674: Make ULocale tests work better with Android. ULocale has been updated to work with scripts and Unicode extensions in the Android Locale, so the tests can be updated to expect this to behave essentially like Java 7. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/37432

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPI.java View 4 chunks +7 lines, -4 lines 1 comment Download
M main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java View 2 chunks +5 lines, -1 line 3 comments Download

Messages

Total messages: 5
roubert (google)
9 years, 6 months ago (2015-05-12 17:51:13 UTC) #1
markus.icu
otherwise LGTM https://codereview.appspot.com/235430043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPI.java File main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPI.java (right): https://codereview.appspot.com/235430043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPI.java#newcode26 main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPI.java:26: import com.ibm.icu.dev.test.TestUtil.JavaVendor; see comment next file https://codereview.appspot.com/235430043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java ...
9 years, 6 months ago (2015-05-12 18:05:15 UTC) #2
roubert (google)
https://codereview.appspot.com/235430043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java File main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java (right): https://codereview.appspot.com/235430043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java#newcode27 main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java:27: import com.ibm.icu.dev.test.TestUtil.JavaVendor; On 2015/05/12 18:05:15, markus.icu wrote: > You ...
9 years, 6 months ago (2015-05-12 18:09:29 UTC) #3
markus.icu
https://codereview.appspot.com/235430043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java File main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java (right): https://codereview.appspot.com/235430043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java#newcode27 main/tests/core/src/com/ibm/icu/dev/test/util/ULocaleTest.java:27: import com.ibm.icu.dev.test.TestUtil.JavaVendor; Oh, never mind :-/ Please commit the ...
9 years, 6 months ago (2015-05-12 18:29:36 UTC) #4
roubert (google)
9 years, 6 months ago (2015-05-12 18:38:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 37432 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b