Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167)

Issue 2353041: Upgrade to caja r4291; Add unit tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by chirag
Modified:
15 years, 3 months ago
Reviewers:
dev-remailer, Jasvir
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This change upgrades to caja r4291 and introduces a few unit tests for CajaContentRewriter. This version of caja will preserve XMLNS declarations in the DOM Parser which is required by SHINDIG-1290. https://issues.apache.org/jira/browse/SHINDIG-1290 http://codereview.appspot.com/2183044/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make tests less fragile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -1 line) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java View 1 1 chunk +173 lines, -0 lines 0 comments Download
pom.xml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
chirag
15 years, 3 months ago (2010-10-01 18:50:53 UTC) #1
Jasvir
http://codereview.appspot.com/2353041/diff/1/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java File java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java (right): http://codereview.appspot.com/2353041/diff/1/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java#newcode140 java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java:140: private void testMarkup(String markup, String expected) throws GadgetException{ Golden ...
15 years, 3 months ago (2010-10-01 19:54:46 UTC) #2
chirag
Make tests less fragile
15 years, 3 months ago (2010-10-01 22:48:27 UTC) #3
chirag
15 years, 3 months ago (2010-10-01 22:48:50 UTC) #4
http://codereview.appspot.com/2353041/diff/1/java/gadgets/src/test/java/org/a...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java
(right):

http://codereview.appspot.com/2353041/diff/1/java/gadgets/src/test/java/org/a...
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java:140:
private void testMarkup(String markup, String expected) throws GadgetException{
On 2010/10/01 19:54:46, jasvir wrote:
> Golden tests are fragile if new errors and warnings are introduced.  Does it
> make sense to split "expected" into a expected output and an array of messages
> that actual .contains()?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b