Issue 234940043: Handle PHASE_NESTABLE_COMPLETE for NESTABLE_ASYNC{0,1,2}(), a new scoped

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 234940043: Handle PHASE_NESTABLE_COMPLETE for NESTABLE_ASYNC{0,1,2}(), a new scoped (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by dbeam1

Modified:
10 years, 2 months ago

Reviewers:
nduca, Dan Beam

CC:
trace-viewer-review_googlegroups.com, xunjieli

Base URL:
https://chromium.googlesource.com/external/trace-viewer.git@master

Visibility:
Public.

More Reviews

Description

Handle PHASE_NESTABLE_COMPLETE for NESTABLE_ASYNC{0,1,2}(), a new scoped variation of the NESTED_ASYNC* family. R=nduca@chromium.org CC=xunjieli@chromium.org BUG=none

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	trace_viewer/extras/importer/trace_event_importer.html	View		7 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Dan Beam

10 years, 2 months ago (2015-04-30 04:40:29 UTC) #1

accompanies https://codereview.chromium.org/1072133006/

Expand All Messages | Collapse All Messages