Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(171)

Issue 2348042: Factor out thread setup/teardown, join threads by name, MacOS fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by pheller
Modified:
15 years, 4 months ago
Reviewers:
ced, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Factored out common thread setup/teardown, fix socket close/shutdown on mac #

Total comments: 3

Patch Set 3 : Fixes per ced. Tested dupe thread names ok. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -102 lines) Patch
A trytond/protocols/common.py View 1 chunk +37 lines, -0 lines 0 comments Download
M trytond/protocols/jsonrpc.py View 2 chunks +7 lines, -30 lines 0 comments Download
M trytond/protocols/netrpc.py View 4 chunks +4 lines, -7 lines 0 comments Download
M trytond/protocols/webdav.py View 2 3 chunks +7 lines, -31 lines 0 comments Download
M trytond/protocols/xmlrpc.py View 2 chunks +6 lines, -30 lines 0 comments Download
M trytond/server.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9
ced
http://codereview.appspot.com/2348042/diff/1/trytond/server.py File trytond/server.py (right): http://codereview.appspot.com/2348042/diff/1/trytond/server.py#newcode191 trytond/server.py:191: xmlrpcd.join() Are you sure the main thread return only ...
15 years, 4 months ago (2010-10-03 08:05:46 UTC) #1
yangoon1
15 years, 4 months ago (2010-10-03 11:45:03 UTC) #2
pheller
On 2010/10/03 08:05:46, ced wrote: > http://codereview.appspot.com/2348042/diff/1/trytond/server.py > File trytond/server.py (right): > > http://codereview.appspot.com/2348042/diff/1/trytond/server.py#newcode191 > ...
15 years, 4 months ago (2010-10-03 21:28:46 UTC) #3
ced
On 2010/10/03 21:28:46, pheller wrote: > On 2010/10/03 08:05:46, ced wrote: > > http://codereview.appspot.com/2348042/diff/1/trytond/server.py > ...
15 years, 4 months ago (2010-10-03 21:35:35 UTC) #4
pheller
I've expanded the scope of this a little bit: The service threads all have very ...
15 years, 4 months ago (2010-10-04 18:22:26 UTC) #5
ced
http://codereview.appspot.com/2348042/diff/6001/trytond/protocols/netrpc.py File trytond/protocols/netrpc.py (right): http://codereview.appspot.com/2348042/diff/6001/trytond/protocols/netrpc.py#newcode17 trytond/protocols/netrpc.py:17: threading.Thread.__init__(self, name='NetRPCClientThread') Is there any issue about having same ...
15 years, 4 months ago (2010-10-04 20:27:24 UTC) #6
pheller
On 2010/10/04 20:27:24, ced wrote: > http://codereview.appspot.com/2348042/diff/6001/trytond/protocols/netrpc.py > File trytond/protocols/netrpc.py (right): > > http://codereview.appspot.com/2348042/diff/6001/trytond/protocols/netrpc.py#newcode17 > ...
15 years, 4 months ago (2010-10-04 21:17:41 UTC) #7
pheller
15 years, 4 months ago (2010-10-04 21:18:49 UTC) #8
ced
15 years, 4 months ago (2010-10-06 20:19:39 UTC) #9
Ok for me
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b