Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1443)

Issue 234590043: Fix SEGV of ibus-x11 on wayland (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by fujiwara
Modified:
8 years, 10 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix SEGV of ibus-x11 on wayland In case that ibus-x11 is built with gtk3, GdkDisplay can be GdkWaylandDisplay but not GdkX11Display so GDK_DISPLAY_XDISPLAY() and GDK_WINDOW_XID() does not work in wayland. TEST=client/x11/ibus-x11

Patch Set 1 #

Patch Set 2 : Reviced patch. #

Patch Set 3 : Updated with latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M client/x11/main.c View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
fujiwara
8 years, 10 months ago (2015-05-19 10:45:32 UTC) #1
Peng
On 2015/05/19 10:45:32, fujiwara wrote: lgtm
8 years, 10 months ago (2015-05-19 13:50:00 UTC) #2
fujiwara
Slightly updated.
8 years, 10 months ago (2015-05-20 03:55:40 UTC) #3
Peng
8 years, 10 months ago (2015-05-20 20:07:38 UTC) #4
On 2015/05/20 03:55:40, fujiwara wrote:
> Slightly updated.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b