code review 2344041: fmt: add Errorf helper function

fmt: add Errorf helper function

This crops up in a lot of places.
It's just a one-liner, but doesn't add any dependancies.
Seems worth it.

[adg, 2010-10-01 03:48:06]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-10-01 03:55:47]

On Sep 30, 2010, at 8:48 PM, adg@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> fmt: add Errorf helper function
> 
> This crops up in a lot of places.
> It's just a one-liner, but doesn't add any dependancies.
> Seems worth it.
> 
> Please review this at http://codereview.appspot.com/2344041/
> 
> Affected files:
>  M src/pkg/fmt/print.go
> 
> 
> Index: src/pkg/fmt/print.go
> ===================================================================
> --- a/src/pkg/fmt/print.go
> +++ b/src/pkg/fmt/print.go
> @@ -159,6 +159,12 @@
> 	return s
> }
> 
> +// Errorf formats according to a format specifier and returns the string
> +// converted to an os.ErrorString, which satisfies the os.Error interface.
> +func Errorf(format string, a ...interface{}) os.Error {
> +	return os.NewError(Sprintf(format, a...))
> +}
> +
> // These routines do not take a format string
> 
> // Fprint formats using the default formats for its operands and writes to w.
> 
> 

do what it says without the extra function call.  just return
os.ErrorString(...)

-rob

[adg, 2010-10-01 03:58:59]

On 1 October 2010 13:55, Rob 'Commander' Pike <r@google.com> wrote:
> do what it says without the extra function call.  just return
os.ErrorString(...)

Done.

[r2, 2010-10-01 04:00:53]

LGTM

in another CL you might want to use it in a bunch of extant places.

[adg, 2010-10-01 04:05:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=d1fd4018fa2f ***

fmt: add Errorf helper function

This crops up in a lot of places.
It's just a one-liner, but doesn't add any dependancies.
Seems worth it.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/2344041

[adg, 2010-10-01 04:05:29]

On 1 October 2010 14:00, Rob 'Commander' Pike <r@google.com> wrote:
> LGTM
>
> in another CL you might want to use it in a bunch of extant places.

That's the plan.