Issue 2341050: Add Delegator verifier that check added fields

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2341050: Add Delegator verifier that check added fields

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by zhoresh

Modified:
15 years, 5 months ago

Reviewers:
dev-remailer, jtarrio

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Patch Set 1 #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+107 lines, -291 lines)			Patch
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java	View	1 chunk	+13 lines, -0 lines	0 comments	Download
java/common/src/test/java/org/apache/shindig/protocol/conversion/BeanDelegatorTest.java	View	2 chunks	+23 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java	View	2 chunks	+5 lines, -3 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetHandlerServiceTest.java	View	1 chunk	+0 lines, -287 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java	View	4 chunks	+66 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jtarrio

lgtm, with two typos :) If I put these comments in the file I get ...

15 years, 5 months ago (2010-10-08 21:26:27 UTC) #2

zhoresh

15 years, 5 months ago (2010-10-09 00:11:16 UTC) #3

On 2010/10/08 21:26:27, jtarrio wrote:
> lgtm, with two typos :)
> 
> If I put these comments in the file I get an error 500, but look for
> "FromExcepton" and "gagget" in GadgetsHandlerServiceTest.java :)

Thanks for the review. Updated spelling and committed as r1006080

Expand All Messages | Collapse All Messages