code review 2336044: Adds support for absolute exported Int values in expvar.

expvar: add (*Int).Set

[adg, 2010-10-11 03:19:52]

LGTM
but:

http://codereview.appspot.com/2336044/diff/1/src/pkg/expvar/expvar.go
File src/pkg/expvar/expvar.go (right):

http://codereview.appspot.com/2336044/diff/1/src/pkg/expvar/expvar.go#newcode47
src/pkg/expvar/expvar.go:47: // Add atomically adds the given delta to the
underlying Int.
Lose these comments, they are obvious and there aren't any on the other types in
this package.

However, it might be worth adding a comment to the package docs that all updates
are atomic.

http://codereview.appspot.com/2336044/diff/1/src/pkg/expvar/expvar.go#newcode54
src/pkg/expvar/expvar.go:54: // Set atomically sets the value of the underlying
Int.
ditto

[Sam, 2010-10-11 06:28:55]

http://codereview.appspot.com/2336044/diff/1/src/pkg/expvar/expvar.go
File src/pkg/expvar/expvar.go (right):

http://codereview.appspot.com/2336044/diff/1/src/pkg/expvar/expvar.go#newcode47
src/pkg/expvar/expvar.go:47: // Add atomically adds the given delta to the
underlying Int.
On 2010/10/11 03:19:52, adg wrote:
> Lose these comments, they are obvious and there aren't any on the other types
in
> this package.
> 
> However, it might be worth adding a comment to the package docs that all
updates
> are atomic.

Done.

http://codereview.appspot.com/2336044/diff/1/src/pkg/expvar/expvar.go#newcode54
src/pkg/expvar/expvar.go:54: // Set atomically sets the value of the underlying
Int.
On 2010/10/11 03:19:52, adg wrote:
> ditto

Done.

[Sam, 2010-10-11 06:44:48]

Hello golang-dev@googlegroups.com, adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-10-11 15:33:24]

LGTM

but change the CL description to

expvar: add (*Int).Set

see the discussion of CL descriptions in
http://golang.org/doc/contribute.html
(make a change).

russ

[Sam, 2010-10-11 17:00:30]

Done, re-uploaded. Can you submit?

On Mon, Oct 11, 2010 at 08:33, Russ Cox <rsc@golang.org> wrote:
> LGTM
>
> but change the CL description to
>
> expvar: add (*Int).Set
>
> see the discussion of CL descriptions in
> http://golang.org/doc/contribute.html
> (make a change).
>
> russ
>

[rsc, 2010-10-11 17:14:10]

*** Submitted as 011cc585549a ***

expvar: add (*Int).Set

R=golang-dev, adg, rsc
CC=golang-dev
http://codereview.appspot.com/2336044

Committer: Russ Cox <rsc@golang.org>