Issue 2333043: code review 2333043: fix arm build on darwin leopard

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2333043: code review 2333043: fix arm build on darwin leopard (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:
r2

CC:
r, golang-dev

Visibility:
Public.

Description

fix arm build on darwin leopard

Patch Set 1 #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/libcgo/Makefile	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-09-30 18:48:31 UTC) #1

rsc

*** Submitted as 1858482760c1 *** fix arm build on darwin leopard TBR=r CC=golang-dev http://codereview.appspot.com/2333043

14 years, 5 months ago (2010-09-30 18:48:35 UTC) #2

14 years, 5 months ago (2010-09-30 18:55:46 UTC) #3

LGTM

On Sep 30, 2010, at 11:48 AM, rsc@golang.org wrote:

> *** Submitted as 1858482760c1 ***
> 
> fix arm build on darwin leopard
> 
> TBR=r
> CC=golang-dev
> http://codereview.appspot.com/2333043
> 
> 
> http://codereview.appspot.com/2333043/

Expand All Messages | Collapse All Messages