Issue 23330046: Handle api_searchs with ~user

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23330046: Handle api_searchs with ~user

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by bac

Modified:
10 years, 5 months ago

Reviewers:
gary.poster, mp+195439

Visibility:
Public.

Description

Handle api_searchs with ~user Treat them as a search "owner: user" as we do in the in-site search. Also don't puke if special characters in the user-entered search cause an ElasticHttpError. https://code.launchpad.net/~bac/charmworld/fix-search-api/+merge/195439 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/search.py	View	4 chunks	+21 lines, -7 lines	1 comment	Download
M	charmworld/tests/test_search.py	View	2 chunks	+30 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gary.poster

10 years, 5 months ago (2013-11-15 19:48:03 UTC) #2

LGTM with changes per call.  Thank you!

Gary

https://codereview.appspot.com/23330046/diff/1/charmworld/search.py
File charmworld/search.py (right):

https://codereview.appspot.com/23330046/diff/1/charmworld/search.py#newcode392
charmworld/search.py:392: return {'prefix': {field: text}}
We agreed you would revert this chunk...

https://codereview.appspot.com/23330046/diff/1/charmworld/tests/test_search.py
File charmworld/tests/test_search.py (right):

https://codereview.appspot.com/23330046/diff/1/charmworld/tests/test_search.p...
charmworld/tests/test_search.py:444: def test_tilde_matches_owner(self):
...and remove this, and land.

Expand All Messages | Collapse All Messages