Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 232440044: Load locale compose files dynamically. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by fujiwara
Modified:
9 years, 6 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Load locale compose files dynamically. $HOME/.XCompose is used for the customization of compose files. Now the static system locale data is dropped and load /usr/share/X11/locale/$LOCALE/Compose dynamically besides .XCompose. BUG=https://code.google.com/p/ibus/issues/detail?id=1728 TEST=src/libibus.so src/tests/ibus-compose engine/ibus-engine-simple

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5841 lines, -5998 lines) Patch
D bindings/vala/ibus-private.vapi View 1 chunk +0 lines, -22 lines 0 comments Download
M engine/Makefile.am View 3 chunks +3 lines, -26 lines 0 comments Download
M engine/main.vala View 1 2 chunks +17 lines, -4 lines 0 comments Download
D engine/test-compose.vala View 1 chunk +0 lines, -193 lines 0 comments Download
M src/Makefile.am View 3 chunks +3 lines, -20 lines 0 comments Download
D src/gencomposetable.c View 1 chunk +0 lines, -968 lines 0 comments Download
M src/ibuscomposetable.h View 3 chunks +29 lines, -2055 lines 0 comments Download
A + src/ibuscomposetable.c View 32 chunks +179 lines, -339 lines 0 comments Download
M src/ibusenginesimple.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/ibusenginesimple.c View 4 chunks +44 lines, -46 lines 0 comments Download
M src/keyname-table.h View 21 chunks +5297 lines, -2323 lines 0 comments Download
M src/tests/Makefile.am View 3 chunks +10 lines, -2 lines 0 comments Download
A src/tests/ibus-compose.c View 1 1 chunk +245 lines, -0 lines 0 comments Download
M src/tests/runtest View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
fujiwara
9 years, 6 months ago (2015-05-14 10:43:21 UTC) #1
Peng
lgtm https://codereview.appspot.com/232440044/diff/1/engine/main.vala File engine/main.vala (right): https://codereview.appspot.com/232440044/diff/1/engine/main.vala#newcode68 engine/main.vala:68: var home = GLib.Environment.get_variable("HOME"); Use this http://valadoc.org/#!api=glib-2.0/GLib.Environment.get_home_dir ?
9 years, 6 months ago (2015-05-15 21:50:16 UTC) #2
fujiwara
9 years, 6 months ago (2015-05-18 02:54:16 UTC) #3
https://codereview.appspot.com/232440044/diff/1/engine/main.vala
File engine/main.vala (right):

https://codereview.appspot.com/232440044/diff/1/engine/main.vala#newcode68
engine/main.vala:68: var home = GLib.Environment.get_variable("HOME");
On 2015/05/15 21:50:16, Peng wrote:
> Use this http://valadoc.org/#!api=glib-2.0/GLib.Environment.get_home_dir ?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b