Issue 232440044: Load locale compose files dynamically.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 232440044: Load locale compose files dynamically. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 1 month ago by fujiwara

Modified:
9 years, 1 month ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Load locale compose files dynamically. $HOME/.XCompose is used for the customization of compose files. Now the static system locale data is dropped and load /usr/share/X11/locale/$LOCALE/Compose dynamically besides .XCompose. BUG=https://code.google.com/p/ibus/issues/detail?id=1728 TEST=src/libibus.so src/tests/ibus-compose engine/ibus-engine-simple

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5841 lines, -5998 lines)			Patch
D	bindings/vala/ibus-private.vapi	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	engine/Makefile.am	View		3 chunks	+3 lines, -26 lines	0 comments	Download
M	engine/main.vala	View	1	2 chunks	+17 lines, -4 lines	0 comments	Download
D	engine/test-compose.vala	View		1 chunk	+0 lines, -193 lines	0 comments	Download
M	src/Makefile.am	View		3 chunks	+3 lines, -20 lines	0 comments	Download
D	src/gencomposetable.c	View		1 chunk	+0 lines, -968 lines	0 comments	Download
M	src/ibuscomposetable.h	View		3 chunks	+29 lines, -2055 lines	0 comments	Download
A +	src/ibuscomposetable.c	View		32 chunks	+179 lines, -339 lines	0 comments	Download
M	src/ibusenginesimple.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/ibusenginesimple.c	View		4 chunks	+44 lines, -46 lines	0 comments	Download
M	src/keyname-table.h	View		21 chunks	+5297 lines, -2323 lines	0 comments	Download
M	src/tests/Makefile.am	View		3 chunks	+10 lines, -2 lines	0 comments	Download
A	src/tests/ibus-compose.c	View	1	1 chunk	+245 lines, -0 lines	0 comments	Download
M	src/tests/runtest	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/232440044/diff/1/engine/main.vala File engine/main.vala (right): https://codereview.appspot.com/232440044/diff/1/engine/main.vala#newcode68 engine/main.vala:68: var home = GLib.Environment.get_variable("HOME"); Use this http://valadoc.org/#!api=glib-2.0/GLib.Environment.get_home_dir ?

9 years, 1 month ago (2015-05-15 21:50:16 UTC) #2

fujiwara

9 years, 1 month ago (2015-05-18 02:54:16 UTC) #3

https://codereview.appspot.com/232440044/diff/1/engine/main.vala
File engine/main.vala (right):

https://codereview.appspot.com/232440044/diff/1/engine/main.vala#newcode68
engine/main.vala:68: var home = GLib.Environment.get_variable("HOME");
On 2015/05/15 21:50:16, Peng wrote:
> Use this http://valadoc.org/#!api=glib-2.0/GLib.Environment.get_home_dir ?

Done.

Expand All Messages | Collapse All Messages