Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(230)

Issue 232040043: Add units to memory allocator dump attributes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by petrcermak
Modified:
10 years, 3 months ago
Reviewers:
primiano, nduca
CC:
trace-viewer-review_googlegroups.com
Base URL:
git@github.com:google/trace-viewer@master
Visibility:
Public.

Description

Add units to memory allocator dump attributes This patch aligns the attributes used by memory allocator dumps with telemetry values (https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/value/__init__.py) by introducing a 'units' field. This leads to the following transformation: ScalarAttribute(x) -> ScalarAttribute('objects', x) BytesAttribute(x) -> ScalarAttribute('bytes', x) This patch also renames the allocated_objects_count field to objects_count. BUG=#849 R=nduca@chromium.org, primiano@chromium.org Committed: https://chromium.googlesource.com/external/trace-viewer/+/ba605a208707d32e80f630ea0d0ecef61cd6cb7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -255 lines) Patch
M trace_viewer/core/analysis/memory_dump_overview_pane_test.html View 2 chunks +8 lines, -9 lines 0 comments Download
M trace_viewer/core/analysis/memory_dump_process_pane.html View 1 chunk +1 line, -1 line 0 comments Download
M trace_viewer/core/analysis/memory_dump_process_pane_test.html View 2 chunks +8 lines, -9 lines 0 comments Download
M trace_viewer/core/analysis/single_global_memory_dump_sub_view_test.html View 2 chunks +8 lines, -9 lines 0 comments Download
M trace_viewer/core/trace_model/attribute.html View 7 chunks +75 lines, -65 lines 0 comments Download
M trace_viewer/core/trace_model/attribute_test.html View 3 chunks +94 lines, -81 lines 0 comments Download
M trace_viewer/core/trace_model/process_memory_dump_test.html View 7 chunks +56 lines, -51 lines 0 comments Download
M trace_viewer/core/tracks/global_memory_dump_track_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M trace_viewer/extras/importer/trace_event_importer_test.html View 6 chunks +44 lines, -28 lines 0 comments Download

Messages

Total messages: 5
petrcermak
Hi, please review this patch. Thanks, Petr
10 years, 3 months ago (2015-04-27 12:34:46 UTC) #1
primiano
Makes sense, LGTM.
10 years, 3 months ago (2015-04-27 12:53:46 UTC) #2
petrcermak
Hi Nat, please review this change, which modifies the memory allocator dump attributes to be ...
10 years, 3 months ago (2015-04-27 14:41:45 UTC) #3
nduca
lgtm
10 years, 3 months ago (2015-04-27 14:44:33 UTC) #4
petrcermak
10 years, 3 months ago (2015-04-27 14:48:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba605a208707d32e80f630ea0d0ecef61cd6cb7e (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b