Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 2319041: code review 2319041: go ast/parser/printer: permit elision of composite lite... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by gri
Modified:
10 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go ast/parser/printer: permit elision of composite literal types for composite literal elements gofmt: added -s flag to simplify composite literal expressions through type elision where possible

Patch Set 1 #

Patch Set 2 : code review 2319041: go ast/parser/printer: permit elision of composite lite... #

Total comments: 1

Patch Set 3 : code review 2319041: go ast/parser/printer: permit elision of composite lite... #

Patch Set 4 : code review 2319041: go ast/parser/printer: permit elision of composite lite... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -25 lines) Patch
M src/cmd/gofmt/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/gofmt/doc.go View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gofmt/gofmt.go View 2 2 chunks +5 lines, -0 lines 0 comments Download
A src/cmd/gofmt/simplify.go View 1 chunk +57 lines, -0 lines 0 comments Download
A src/cmd/gofmt/testdata/composites.golden View 2 1 chunk +104 lines, -0 lines 0 comments Download
A src/cmd/gofmt/testdata/composites.input View 2 1 chunk +104 lines, -0 lines 0 comments Download
A src/cmd/gofmt/testdata/test.sh View 1 chunk +65 lines, -0 lines 0 comments Download
M src/pkg/go/ast/ast.go View 2 chunks +8 lines, -3 lines 0 comments Download
M src/pkg/go/parser/parser.go View 1 4 chunks +11 lines, -8 lines 0 comments Download
M src/pkg/go/parser/parser_test.go View 1 chunk +13 lines, -11 lines 0 comments Download
M src/pkg/go/printer/nodes.go View 1 chunk +4 lines, -1 line 0 comments Download
M src/pkg/go/printer/testdata/expressions.golden View 1 chunk +21 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.input View 1 chunk +21 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.raw View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5
gri
Hello golang-dev@googlegroups.com, I'd like you to review this change.
10 years ago (2010-10-21 23:36:57 UTC) #1
rsc1
please add the test case from exp/4s. http://codereview.appspot.com/2319041/diff/2001/src/cmd/gofmt/gofmt.go File src/cmd/gofmt/gofmt.go (right): http://codereview.appspot.com/2319041/diff/2001/src/cmd/gofmt/gofmt.go#newcode27 src/cmd/gofmt/gofmt.go:27: simplifyAST = ...
10 years ago (2010-10-22 02:27:53 UTC) #2
gri
PTAL On Thu, Oct 21, 2010 at 7:27 PM, <rsc@google.com> wrote: > please add the ...
10 years ago (2010-10-22 16:36:27 UTC) #3
rsc1
LGTM
10 years ago (2010-10-22 17:00:25 UTC) #4
gri
10 years ago (2010-10-22 17:03:24 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=1a1a5367cd9b ***

go ast/parser/printer: permit elision of composite literal types for composite
literal elements
gofmt: added -s flag to simplify composite literal expressions through type
elision where possible

R=rsc
CC=golang-dev
http://codereview.appspot.com/2319041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b