code review 2319041: go ast/parser/printer: permit elision of composite lite...

go ast/parser/printer: permit elision of composite literal types for composite literal elements
gofmt: added -s flag to simplify composite literal expressions through type elision where possible

[gri, 2010-10-21 23:36:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[rsc1, 2010-10-22 02:27:53]

please add the test case from exp/4s.

http://codereview.appspot.com/2319041/diff/2001/src/cmd/gofmt/gofmt.go
File src/cmd/gofmt/gofmt.go (right):

http://codereview.appspot.com/2319041/diff/2001/src/cmd/gofmt/gofmt.go#newcode27
src/cmd/gofmt/gofmt.go:27: simplifyAST = flag.Bool("s", false, "simplify source
by removing some redundent code")
maybe just "simplify code"
and leave it open-ended for future changes?

[gri, 2010-10-22 16:36:27]

PTAL

On Thu, Oct 21, 2010 at 7:27 PM, <rsc@google.com> wrote:

> please add the test case from exp/4s.
>
>
>
>
> http://codereview.appspot.com/2319041/diff/2001/src/cmd/gofmt/gofmt.go
> File src/cmd/gofmt/gofmt.go (right):
>
>
>
http://codereview.appspot.com/2319041/diff/2001/src/cmd/gofmt/gofmt.go#newcode27
> src/cmd/gofmt/gofmt.go:27: simplifyAST = flag.Bool("s", false, "simplify
> source by removing some redundent code")
> maybe just "simplify code"
> and leave it open-ended for future changes?
>
>
> http://codereview.appspot.com/2319041/
>

[rsc1, 2010-10-22 17:00:25]

LGTM

[gri, 2010-10-22 17:03:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=1a1a5367cd9b ***

go ast/parser/printer: permit elision of composite literal types for composite
literal elements
gofmt: added -s flag to simplify composite literal expressions through type
elision where possible

R=rsc
CC=golang-dev
http://codereview.appspot.com/2319041